Skip to content

Step global TODO counter when using task(todo) option - #79

Merged
rabuu merged 2 commits into
mainfrom
fix-todo-propagation
Mar 30, 2026
Merged

Step global TODO counter when using task(todo) option#79
rabuu merged 2 commits into
mainfrom
fix-todo-propagation

Conversation

@rabuu

@rabuu rabuu commented Mar 16, 2026

Copy link
Copy Markdown
Owner

Describe your changes

When adding the todo option for the task function (#60), we forgot to also step the global TODO counter. This is fixed now.

Somewhat unrelated, this PR also deletes some unused code in the task-local todo mechanic.

Related issues and/or PRs

Fixes #78.

Checklist

  • The test suite passes
  • The code is formatted
  • The code is readable and well-documented
  • Every word that can be in the output is translatable
  • All new features are reflected in a test or example
  • All new examples have a generated associated test
  • Changes to the public API are documented in the CHANGELOG
  • All related PRs and issues are linked
  • An appropriate label is chosen

@rabuu
rabuu requested a review from leanderhert March 16, 2026 14:02
@rabuu rabuu added the bug Something isn't working label Mar 16, 2026

@leanderhert leanderhert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rabuu
rabuu merged commit ab9180e into main Mar 30, 2026
2 checks passed
@rabuu
rabuu deleted the fix-todo-propagation branch March 30, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task(todo: true) does not propagate to title

2 participants